Set default value for "state_path". #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces default state path functionality for ACME issuers and adds support for disabling state persistence with the "off" value. The change addresses issue #32 by automatically generating state paths based on the issuer name when not explicitly configured.
- Adds automatic generation of default state paths using "acme_{issuer.name}" pattern
- Introduces "off" special value to disable state persistence (stateless behavior)
- Adds build-time configuration option NGX_ACME_STATE_PREFIX for custom state path prefixes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/conf/issuer.rs | Implements default state path generation logic and NGX_CONF_UNSET_PTR usage |
| src/conf.rs | Adds custom command handler for state_path to support "off" value |
| README.md | Documents new build option and updated state_path syntax |
| t/acme_conf_issuer.t | Updates test configurations to include explicit state_path settings |
| t/acme_conf_certificate.t | Updates test configuration to include explicit state_path setting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Set default state_path to "acme_{issuer.name}" and introduce a special
value "off" to revert to a stateless behavior.
As usual, relative paths in configuration are resolved against
NGX_PREFIX. The NGX_ACME_STATE_PREFIX environment variable can be set
during build to override this behavior. The way we take the option may
look a bit unusual, but unfortunately there's no infra for adding
module-specific options in auto/configure.
Fixes nginx#32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default state_path to "acme_{issuer.name}" and introduce a special value "off" to revert to a stateless behavior.
As usual, relative paths in configuration are resolved against NGX_PREFIX. The NGX_ACME_STATE_PREFIX environment variable can be set during build to override this behavior. The way we take the option may look a bit unusual, but unfortunately there's no infra for adding module-specific options in auto/configure.
Fixes #32.