Skip to content

Conversation

bavshin-f5
Copy link
Member

We discovered a server implementation that does not support key rollover and indicates that by not sending "keyChange".
For completeness, I'm marking all the currently unused directory resources as optional.

We discovered a server implementation that does not support key rollover
and indicates that by not sending "keyChange".
For completeness, I'm marking all the currently unused directory
resources as optional.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ACME directory resource fields to handle server implementations that don't support all directory resources, specifically addressing servers that don't support key rollover by not sending "keyChange".

  • Changes revoke_cert and key_change fields from required Uri to optional Option<Uri>
  • Updates serde attributes to use optional URI deserialization with default values

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@ensh63 ensh63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment: unused fields may be removed from structure definition. If desired, they definitions may be commented out to simplify restoring when code will use them.

@bavshin-f5 bavshin-f5 merged commit e929adb into nginx:main Sep 23, 2025
14 checks passed
@bavshin-f5 bavshin-f5 deleted the optional-resources branch September 23, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants