Docs: clarify build requirements and SSL library support. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the documentation by clarifying build requirements and SSL library compatibility for the nginx-acme module. It addresses issues #36 and #53 by providing more detailed guidance on version requirements and SSL library matching.
- Added specific NGINX version requirement (1.25.0+) and pkg-config dependency
- Added comprehensive SSL library compatibility section explaining the importance of matching SSL implementations
- Added documentation versioning note to clarify current vs. released documentation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ensh63
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the N+ compatibility note is acceptable here, but it seems necessary after the previous paragraph.
Fixes #36
Fixes #53 by explicitly stating that mismatched SSL libraries are unsupported and pointing to the compatibility table.