Make: refactor dynamic module builds. #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Makefile structure for dynamic module builds by standardizing variable names and introducing proper separation between Cargo-built modules and nginx-built modules. It also adds BoringSSL configuration support for testing purposes.
- Renamed
NGX_MODEXTtoSHLIB_EXTfor better clarity - Replaced hardcoded module paths with standardized variables (
CARGO_DEBUG_MODULE,CARGO_RELEASE_MODULE,NGINX_BUILT_MODULE) - Added BoringSSL build configurations for both dynamic and static linking
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| build/compat-posix.mk | Renamed NGX_MODEXT to SHLIB_EXT for BSD make compatibility |
| build/compat-gnu.mk | Renamed NGX_MODEXT to SHLIB_EXT for GNU make compatibility |
| build/build-release.mk | Replaced hardcoded module paths with standardized variables |
| build/build-debug.mk | Replaced hardcoded module paths with standardized variables |
| build/build-boringssl.mk | Added new BoringSSL dynamic module build configuration |
| build/build-boringssl-static.mk | Added new BoringSSL static module build configuration |
| build/build-aws-lc.mk | Updated to use standardized variables and improved target structure |
| Makefile | Introduced clear separation between module name, target name, and standardized path variables |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bavshin-f5
force-pushed
the
make-dynamic-mods
branch
2 times, most recently
from
29da491 to
cffe9a6
Compare
Define all the shared module targets in the main Makefile and allow build/*.mk files to add the correct dependencies.
bavshin-f5
force-pushed
the
make-dynamic-mods
branch
from
cffe9a6 to
e21bbfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline with @ensh63, the Makefile change in #65 was incomplete. Added suggested changes to fixup and extracted to a separate PR.
I'm also adding BoringSSL configs because it is tiresome and annoying to sync these between machines for testing. Just a reminder that this still requires using a git snapshot of rust-openssl.