Skip to content

Conversation

@bavshin-f5
Copy link
Member

No description provided.

@bavshin-f5 bavshin-f5 requested a review from Copilot November 17, 2025 18:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CI workflows for FreeBSD and NetBSD VMs, replacing the shell-based pebble download script with a more flexible Perl implementation that supports additional platforms and can build from source when prebuilt binaries are unavailable.

Key changes:

  • Replaced build/get-pebble.sh with build/get-pebble.pl for cross-platform compatibility
  • Added new VM workflow file for FreeBSD and NetBSD testing
  • Updated existing CI workflows to use the new Perl script and added concurrency controls

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
build/get-pebble.sh Removed shell script for downloading pebble
build/get-pebble.pl Added Perl script with prebuilt download support and build-from-source fallback
.github/workflows/vmactions.yaml New workflow for FreeBSD and NetBSD VM testing
.github/workflows/sanitizers.yaml Updated to use new pebble script and added concurrency controls
.github/workflows/ci.yaml Updated to use new pebble script and added concurrency controls
.github/dependabot.yml Added allow configuration for Cargo dependency updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Shell implementation of get-pebble started getting too unwieldy,
so it's been rewritten in Perl.
@bavshin-f5 bavshin-f5 merged commit 728dbc8 into nginx:main Nov 17, 2025
22 checks passed
@bavshin-f5 bavshin-f5 deleted the build-pebble branch November 17, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants