- 
                Notifications
    
You must be signed in to change notification settings  - Fork 140
 
Adding logging to functional tests #3781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #3781      +/-   ##
==========================================
+ Coverage   86.83%   86.84%   +0.01%     
==========================================
  Files         128      128              
  Lines       16500    16500              
  Branches       62       62              
==========================================
+ Hits        14328    14330       +2     
+ Misses       1994     1993       -1     
+ Partials      178      177       -1     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
a2f5c82    to
    156a037      
    Compare
  
    
              
                    sjberman
  
              
              reviewed
              
                  
                    Aug 22, 2025 
                  
              
              
            
            
4787775    to
    a51d45e      
    Compare
  
    a51d45e    to
    fe688a8      
    Compare
  
    
              
                    sjberman
  
              
              reviewed
              
                  
                    Sep 2, 2025 
                  
              
              
            
            
fe688a8    to
    b0cd789      
    Compare
  
    
              
                    ciarams87
  
              
              reviewed
              
                  
                    Sep 3, 2025 
                  
              
              
            
            
b0cd789    to
    d394c64      
    Compare
  
    
              
                    tataruty
  
              
              commented
              
                  
                    Sep 4, 2025 
                  
              
              
            
            
0125c08    to
    e1f3c02      
    Compare
  
    
              
                    sjberman
  
              
              approved these changes
              
                  
                    Sep 8, 2025 
                  
              
              
            
            
              
                    ciarams87
  
              
              approved these changes
              
                  
                    Sep 8, 2025 
                  
              
              
            
            
5e8513d    to
    e9fc351      
    Compare
  
    e9fc351    to
    bc729b5      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Proposed changes
Problem: As a developer of NGF
I want the NFR and functional tests to log as they execute
So I can more easily debug a failure when it occurs.
Solution: - Log statements are added to all non-functional and functional tests to include assertions, requests, responses, and anywhere there is a chance for an error to occur.
Testing: Tested with Plus and without, compared failures output with new logging and without
Closes #2449
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes