Skip to content

Conversation

tataruty
Copy link
Contributor

@tataruty tataruty commented Aug 22, 2025

Proposed changes

Problem: As a developer of NGF
I want the NFR and functional tests to log as they execute
So I can more easily debug a failure when it occurs.

Solution: - Log statements are added to all non-functional and functional tests to include assertions, requests, responses, and anywhere there is a chance for an error to occur.

Testing: Tested with Plus and without, compared failures output with new logging and without

Closes #2449

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@tataruty tataruty requested a review from a team as a code owner August 22, 2025 12:48
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 22, 2025
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.84%. Comparing base (9d69c44) to head (f8f6b24).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3781      +/-   ##
==========================================
+ Coverage   86.83%   86.84%   +0.01%     
==========================================
  Files         128      128              
  Lines       16500    16500              
  Branches       62       62              
==========================================
+ Hits        14328    14330       +2     
+ Misses       1994     1993       -1     
+ Partials      178      177       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from a2f5c82 to 156a037 Compare August 22, 2025 12:52
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch 3 times, most recently from 4787775 to a51d45e Compare August 25, 2025 11:07
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from a51d45e to fe688a8 Compare September 2, 2025 15:55
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from fe688a8 to b0cd789 Compare September 3, 2025 07:47
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from b0cd789 to d394c64 Compare September 4, 2025 12:55
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch 3 times, most recently from 0125c08 to e1f3c02 Compare September 8, 2025 11:23
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch 3 times, most recently from 5e8513d to e9fc351 Compare September 11, 2025 08:20
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from e9fc351 to bc729b5 Compare September 11, 2025 10:31
@tataruty tataruty merged commit e033d56 into main Sep 11, 2025
86 of 88 checks passed
@tataruty tataruty deleted the tests/improve_functional_tests_logging branch September 11, 2025 17:09
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants