NFR Test Results for NGF version edge #2496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2496 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 100 100
Lines 7539 7539
Branches 50 50
=======================================
Hits 6726 6726
Misses 756 756
Partials 57 57 ☔ View full report in Codecov by Sentry. |
|
Looks like we need to fix the results writer to format the end of some files...pre-commit is failing. |
|
I also wonder if we need to reconsider uploading entire log files... |
Problem: Some results files added extra newlines, causing our formatter to fail. Also, error log files were way too large for feasible parsing. Solution: Remove extra newlines, and only include error logs instead of full log files.
|
I've pushed some fixes to a branch and will see if that helps after the test run completes. |
nginx-bot
force-pushed
the
tests/nfr-tests-edge
branch
from
64fcb99 to
38ab460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update with NFR test results for NGF version edge ["oss","plus"]