Skip to content

Conversation

salonichf5
Copy link
Contributor

Deploy doc updates for release 1.5.0

@salonichf5 salonichf5 requested review from a team as code owners November 21, 2024 21:18
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests helm-chart Relates to helm chart labels Nov 21, 2024
@salonichf5 salonichf5 closed this Nov 21, 2024
@salonichf5 salonichf5 reopened this Nov 21, 2024
@salonichf5 salonichf5 changed the base branch from main to release-1.5 November 21, 2024 21:18
@sjberman
Copy link
Collaborator

sjberman commented Nov 21, 2024

You also need

  push:
    branches:
    - release-1.5
    paths:
    - "site/**"

See https://github.com/nginxinc/nginx-gateway-fabric/pull/2597/files as an example (this PR forgot the paths section, however)

@salonichf5 salonichf5 closed this Nov 21, 2024
@salonichf5 salonichf5 reopened this Nov 21, 2024
@github-actions github-actions bot removed tests Pull requests that update tests helm-chart Relates to helm chart labels Nov 21, 2024
@salonichf5
Copy link
Contributor Author

You also need

  push:
    branches:
    - release-1.4
    paths:
    - "site/**"

See https://github.com/nginxinc/nginx-gateway-fabric/pull/2597/files as an example (this PR forgot the paths section, however)

Yes, just fixed it.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (9a1df7a) to head (cad7fb6).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #2796   +/-   ##
============================================
  Coverage        89.86%   89.86%           
============================================
  Files              107      107           
  Lines            10997    10997           
  Branches            50       50           
============================================
  Hits              9883     9883           
  Misses            1054     1054           
  Partials            60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@salonichf5 salonichf5 closed this Nov 21, 2024
@salonichf5 salonichf5 reopened this Nov 21, 2024
@salonichf5 salonichf5 closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants