Skip to content

Update references to new repo (2) #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2025
Merged

Update references to new repo (2) #2985

merged 3 commits into from
Jan 7, 2025

Conversation

@lucacome
Copy link
Contributor

@lucacome lucacome commented Jan 7, 2025 •
edited
Loading

Proposed changes

Updates references, take 2

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested review from a team as code owners January 7, 2025 01:43
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks tests Pull requests that update tests helm-chart Relates to helm chart labels Jan 7, 2025
lucacome
lucacome commented Jan 7, 2025
View reviewed changes
CHANGELOG.md

- Control plane: `ghcr.io/nginxinc/nginx-gateway-fabric:1.5.1`
- Data plane: `ghcr.io/nginxinc/nginx-gateway-fabric/nginx:1.5.1`
- Control plane: `ghcr.io/nginx/nginx-gateway-fabric:1.5.1`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only pushed 1.5.1 to the packages here. Not sure if we want to add all the old ones.

ADubhlaoich
ADubhlaoich approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the docs side.

@lucacome lucacome merged commit ed32933 into nginx:main Jan 7, 2025
29 of 30 checks passed
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Update references to new repo (2) (nginx#2985)
26c4ce0
lucacome added a commit that referenced this pull request Jan 16, 2025
@lucacome
Update references to new repo (2) (#2985)
8cf19f5
@lucacome lucacome deleted the chore/new-repo-2 branch February 19, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@sjberman sjberman sjberman approved these changes

@bjee19 bjee19 bjee19 approved these changes

+1 more reviewer

@kate-osborn kate-osborn kate-osborn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart tests Pull requests that update tests

Projects

NGINX Gateway Fabric
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lucacome @ADubhlaoich @sjberman @kate-osborn @bjee19