Skip to content

Conversation

KR411-prog
Copy link
Contributor

Proposed changes
replace unit test loggers with logr.Discard()

Testing: Ran make unit-test

Closes #3041

Checklist
Before creating a PR, run through this checklist and mark each as complete.

[* ] I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
[
] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@KR411-prog KR411-prog requested a review from a team as a code owner February 2, 2025 22:13
@sindhushiv sindhushiv added this to the v2.0.0 milestone Feb 3, 2025
salonichf5
salonichf5 previously approved these changes Feb 5, 2025
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! I will test it locally and update the status

@salonichf5 salonichf5 self-requested a review February 5, 2025 17:28
@salonichf5 salonichf5 dismissed their stale review February 5, 2025 17:28

Need to test

@sjberman sjberman added chore Pull requests for routine tasks tests Pull requests that update tests tech-debt Short-term pain, long-term benefit and removed chore Pull requests for routine tasks labels Feb 5, 2025
@sjberman sjberman merged commit 12d1bdb into nginx:main Feb 6, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech-debt Short-term pain, long-term benefit tests Pull requests that update tests

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Replace test logger with logr.Discard()

4 participants