Skip to content

Fix revert commit for leader election #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Fix revert commit for leader election #3136

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
740ab42
fix revert commit
salonichf5 Feb 14, 2025
00f2ffa
Add back runnables change and call to nginx provisioner enable
bjee19 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/mode/static/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@
return fmt.Errorf("cannot register event loop: %w", err)
}

if err = mgr.Add(runnables.NewEnableAfterBecameLeader(groupStatusUpdater.Enable)); err != nil {
return fmt.Errorf("cannot register status updater: %w", err)
}

Check warning on line 267 in internal/mode/static/manager.go

View check run for this annotation

Codecov / codecov/patch

internal/mode/static/manager.go#L265-L267 

Added lines #L265 - L267 were not covered by tests

if cfg.ProductTelemetryConfig.Enabled {
dataCollector := telemetry.NewDataCollectorImpl(telemetry.DataCollectorConfig{
K8sClientReader: mgr.GetAPIReader(),
Expand Down
Loading