CP/DP Update non-functional tests #3305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
bjee19
commented
Apr 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3305 +/- ##
===================================================================
- Coverage 89.74% 86.68% -3.06%
===================================================================
Files 109 125 +16
Lines 11150 14447 +3297
Branches 50 62 +12
===================================================================
+ Hits 10007 12524 +2517
- Misses 1083 1785 +702
- Partials 60 138 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjee19
commented
Apr 17, 2025
|
Will post a picture of the updated longevity dashboard soon. |
sjberman
reviewed
Apr 17, 2025
sjberman
reviewed
Apr 18, 2025
sjberman
reviewed
Apr 18, 2025
|
Created #3311 to track enabling upgrade nfr test for 2.1 release. |
|
Here is what the longevity dashboard looks like now, notably we are missing all of the nginx specific metrics. We now only have access the container cpu and memory. Added an additional possible acceptance criteria to #1744 which describes why and would we could do to recover more graphs. |
|
Functional tests do not pass, but the fix should come in when #3275 is merged where another volume is added for agent. |
sjberman
reviewed
Apr 21, 2025
Yep, i don't know if the automated github workflow will work, but manually running works and the results look as expected. |
sjberman
approved these changes
Apr 21, 2025
bjee19
force-pushed
the
tests/update-nfr-cp-dp
branch
from
580823a to
627a31a
Compare
bjee19
force-pushed
the
tests/update-nfr-cp-dp
branch
from
627a31a to
05672e5
Compare
sjberman
approved these changes
Apr 22, 2025
sjberman
added a commit
that referenced
this pull request
Apr 23, 2025
Update non-functional tests for the control plane data plane split. Problem: The non-functional tests do not work for the control plane data plane split changes. Solution: Update non-functional tests. Testing: Scale, Reconfiguration, Performance, and Longevity tests work. Upgrade test doesn't work, however that is sort of planned since the CP/DP split is a breaking change of NGF and thus you can't easily upgrade with zero downtime. --------- Co-authored-by: Saylor Berman <[email protected]>
sjberman
added a commit
that referenced
this pull request
May 6, 2025
Update non-functional tests for the control plane data plane split. Problem: The non-functional tests do not work for the control plane data plane split changes. Solution: Update non-functional tests. Testing: Scale, Reconfiguration, Performance, and Longevity tests work. Upgrade test doesn't work, however that is sort of planned since the CP/DP split is a breaking change of NGF and thus you can't easily upgrade with zero downtime. --------- Co-authored-by: Saylor Berman <[email protected]>
sjberman
added a commit
that referenced
this pull request
May 14, 2025
Update non-functional tests for the control plane data plane split. Problem: The non-functional tests do not work for the control plane data plane split changes. Solution: Update non-functional tests. Testing: Scale, Reconfiguration, Performance, and Longevity tests work. Upgrade test doesn't work, however that is sort of planned since the CP/DP split is a breaking change of NGF and thus you can't easily upgrade with zero downtime. --------- Co-authored-by: Saylor Berman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update non-functional tests for the control plane data plane split.
Problem: The non-functional tests do not work for the control plane data plane split changes.
Solution: Update non-functional tests.
Testing: Scale, Reconfiguration, Performance, and Longevity tests work. Upgrade test doesn't work, however that is sort of planned since the CP/DP split is a breaking change of NGF and thus you can't easily upgrade with zero downtime.
Closes #3010
#2374
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.