Skip to content

Conversation

@sjberman
Copy link
Collaborator

@sjberman sjberman commented Jun 9, 2025

Problem: Due to the 2.0 architectural change, the upgrade test needed to be disabled.

Solution: Re-enable this test now that upgrades work again post-2.0.

Testing: Ran the upgrade test successfully.

Closes #3311

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: Due to the 2.0 architectural change, the upgrade test needed to be disabled.

Solution: Re-enable this test now that upgrades work again post-2.0.
@sjberman sjberman requested a review from a team as a code owner June 9, 2025 15:57
@github-actions github-actions bot added the tests Pull requests that update tests label Jun 9, 2025
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (3b1e64c) to head (2cec4a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3482   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files         127      127           
  Lines       15079    15079           
  Branches       62       62           
=======================================
  Hits        13082    13082           
  Misses       1844     1844           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman enabled auto-merge (squash) June 9, 2025 22:17
@sjberman sjberman merged commit 5e77415 into main Jun 9, 2025
63 of 64 checks passed
@sjberman sjberman deleted the tests/re-enable-upgrade-nfr branch June 9, 2025 22:54
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jun 9, 2025
Copy link

@Bassa75338 Bassa75338 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/suite/upgrade_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Re-enable upgrade nfr test in 2.1

4 participants