Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Problem: The CRD generation is incomplete, the Alpine image tag was inadvertently removed during a rebase, and the RBAC needs to be updated to allow the controller to watch for the WAFPolicies and their status

Solution: Add these changes

Testing: Describe any testing that you did.

Please focus on (optional): I'm adding these changes in a separate PR to make the WAFPolicy controller PR less cluttered.

Related: #3532

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner June 24, 2025 10:04
@github-actions github-actions bot added enhancement New feature or request helm-chart Relates to helm chart labels Jun 24, 2025
@ciarams87 ciarams87 force-pushed the feat/waf-policy-crds branch from 2818ae6 to 111dbda Compare June 24, 2025 10:28
@ciarams87 ciarams87 removed the enhancement New feature or request label Jun 24, 2025
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ciarams87 ciarams87 merged commit d3c3c8d into feat/nap-waf Jun 25, 2025
98 of 100 checks passed
@ciarams87 ciarams87 deleted the feat/waf-policy-crds branch June 25, 2025 06:59
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm-chart Relates to helm chart

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants