Implement basic file fetcher #3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sjberman
reviewed
Jul 2, 2025
sjberman
approved these changes
Jul 2, 2025
bjee19
reviewed
Jul 2, 2025
ciarams87
added a commit
that referenced
this pull request
Jul 9, 2025
Problem: As a user I want NGF to fetch my NAP WAF Policy bundle from a remote location So that this bundle can be applied by the data plane to protect my traffic Solution: Create a Policy Fetcher utility in framework which can pull files from a remote location, as configured in the WafPolicy resource. Implement policy validation via Checksum validation (compute checksum locally and compare to remote provided checksum).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a user
I want NGF to fetch my NAP WAF Policy bundle from a remote location
So that this bundle can be applied by the data plane to protect my traffic
Solution: Create a Policy Fetcher utility in framework which can pull files from a remote location, as configured in the WafPolicy resource.
Implement policy validation via Checksum validation (compute checksum locally and compare to remote provided checksum).
Testing: Ensured the policy can be downloaded from an http location as part of #3454
Closes #3456
Replaces: #3539
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.