Skip to content

Use server side apply for NGF CRDs #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

Use server side apply for NGF CRDs #3589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d9d72c
Use server side apply for NGF CRDs
bjee19 Jul 2, 2025
08d1c3d
Add one more spot change
bjee19 Jul 3, 2025
9f2a25a
Merge branch 'main' into chore/use-server-side-apply
bjee19 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ generate-crds: ## Generate CRDs and Go types using kubebuilder

.PHONY: install-crds
install-crds: ## Install CRDs
kubectl kustomize $(SELF_DIR)config/crd | kubectl apply -f -
kubectl kustomize $(SELF_DIR)config/crd | kubectl apply --server-side -f -

.PHONY: install-gateway-crds
install-gateway-crds: ## Install Gateway API CRDs
Expand Down
2 changes: 1 addition & 1 deletion charts/nginx-gateway-fabric/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ Helm does not upgrade the NGINX Gateway Fabric CRDs during a release upgrade. Be
must [pull the chart](#pulling-the-chart) from GitHub and run the following command to upgrade the CRDs:

```shell
kubectl apply -f crds/
kubectl apply --server-side -f crds/
```

The following warning is expected and can be ignored:
Expand Down
2 changes: 1 addition & 1 deletion charts/nginx-gateway-fabric/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Helm does not upgrade the NGINX Gateway Fabric CRDs during a release upgrade. Be
must [pull the chart](#pulling-the-chart) from GitHub and run the following command to upgrade the CRDs:

```shell
kubectl apply -f crds/
kubectl apply --server-side -f crds/
```

The following warning is expected and can be ignored:
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ This will build the docker images `nginx-gateway-fabric:<your-user>` and `nginx-
If the only change is the image repository and tag, you can update the `kustomization.yaml` file in `deploy/` with the desired values and deployment mainifest and run the following commands:

```shell
kubectl apply -f deploy/crds.yaml
kubectl apply --server-side -f deploy/crds.yaml
kubectl kustomize deploy | kubectl apply -f -
```

Expand Down
Loading