Skip to content

Add worker connections field to nginxproxy #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add worker connections field to nginxproxy #3609

wants to merge 3 commits into from

Conversation

sarthyparty
Copy link
Contributor

@sarthyparty sarthyparty commented Jul 9, 2025 •
edited
Loading

Proposed changes

Problem: Users were unable to configure worker connections

Solution: Add field to nginxproxy that allows users to configure worker connections. Read that field and put it into the main conf.

Testing: Manual testing and unit tests for the new code

Closes #3371

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

@sarthyparty sarthyparty requested a review from a team as a code owner July 9, 2025 20:27
@nginx-bot nginx-bot
Copy link

nginx-bot bot commented Jul 9, 2025

Hi @sarthyparty!

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community label Jul 9, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jul 9, 2025
@sarthyparty sarthyparty force-pushed the feature/worker-connections branch from 64e9f84 to 1dcfdc7 Compare July 9, 2025 20:32
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file tests Pull requests that update tests helm-chart Relates to helm chart labels Jul 9, 2025
@sarthyparty sarthyparty force-pushed the feature/worker-connections branch from 1dcfdc7 to 6e21852 Compare July 9, 2025 20:32
@github-actions github-actions bot removed documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file tests Pull requests that update tests helm-chart Relates to helm chart labels Jul 9, 2025
sjberman
sjberman reviewed Jul 9, 2025
View reviewed changes
@sarthyparty sarthyparty requested a review from sjberman July 9, 2025 21:36
@sarthyparty sarthyparty closed this Jul 9, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman Awaiting requested review from sjberman

Assignees

@sjberman sjberman

Labels
enhancement New feature or request
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for configuring worker_connections
2 participants
@sarthyparty @sjberman