Skip to content

Conversation

@sjberman
Copy link
Collaborator

Problem: The upstream conformance library updated their input validation for some flags, causing our nightly tests to fail.

Solution: Update the way we initialize these flags so that they pass.

Testing: Conformance tests on main branch now pass.

Closes #3584

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: The upstream conformance library updated their input validation for some flags, causing our nightly tests to fail.

Solution: Update the way we initialize these flags so that they pass.
@sjberman sjberman requested a review from a team as a code owner July 14, 2025 17:05
@github-actions github-actions bot added the tests Pull requests that update tests label Jul 14, 2025
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (f8ee6d1) to head (ff09c59).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3624      +/-   ##
==========================================
- Coverage   86.92%   86.87%   -0.06%     
==========================================
  Files         127      127              
  Lines       15287    15287              
  Branches       62       62              
==========================================
- Hits        13288    13280       -8     
- Misses       1846     1852       +6     
- Partials      153      155       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman
Copy link
Collaborator Author

Closing, the change in Gateway API was reverted.

@sjberman sjberman closed this Jul 15, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 15, 2025
@sjberman sjberman deleted the tests/flags branch July 15, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update v1.4 conformance tests implementation flags

2 participants