Skip to content

Adjust logging when resolving endpoints #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
Merged

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Aug 5, 2025

Adjust logging when resolving endpoints so that it no longer sends an error message but is instead a debug log message. Also, add a debug log message upon successful resolving of endpoints.

@bjee19 bjee19 requested a review from a team as a code owner August 5, 2025 21:52
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 5, 2025
@bjee19
Copy link
Contributor Author

bjee19 commented Aug 5, 2025

Verified error message no longer occurs, verified messages are sent when NGF is set to debug log level.

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.03%. Comparing base (cf5260e) to head (ea8239b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3690      +/-   ##
==========================================
- Coverage   87.04%   87.03%   -0.02%     
==========================================
  Files         127      127              
  Lines       15602    15604       +2     
  Branches       62       62              
==========================================
  Hits        13581    13581              
- Misses       1862     1863       +1     
- Partials      159      160       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19 bjee19 enabled auto-merge (squash) August 5, 2025 22:05
@bjee19 bjee19 merged commit 0651c28 into main Aug 5, 2025
83 of 85 checks passed
@bjee19 bjee19 deleted the chore/fix-endpoints-logging branch August 5, 2025 23:29
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants