Skip to content

Add CEL validation test for timeout in ClientSettingsPolicy #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Aug 6, 2025

Proposed changes

Add tests for CEL validation test for timeout in ClientSettingsPolicy

Resolves timeout CEL validation requirement of #3621

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner August 6, 2025 09:23
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 6, 2025
@shaun-nx shaun-nx linked an issue Aug 6, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.15%. Comparing base (1dd7381) to head (df8541b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3695      +/-   ##
==========================================
- Coverage   87.16%   87.15%   -0.01%     
==========================================
  Files         128      128              
  Lines       15779    15779              
  Branches       62       62              
==========================================
- Hits        13753    13752       -1     
- Misses       1866     1867       +1     
  Partials      160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Aug 6, 2025
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaun-nx shaun-nx merged commit 206b84e into main Aug 7, 2025
65 of 66 checks passed
@shaun-nx shaun-nx deleted the tests/cel-clientsettingspolicies-timeout branch August 7, 2025 09:08
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add CEL test for ClientSettingsPolicy CRD
3 participants