-
Notifications
You must be signed in to change notification settings - Fork 131
Add CEL validation tests for NginxProxy #3701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9631d54
Add tests for kubernetes validation
shaun-nx 8455a14
Add tests for rewriteClientIP
shaun-nx 8404b7d
Move validation function to common.go
shaun-nx 0ba4b7c
Add comment to `validateCrd` function
shaun-nx 8032352
Merge branch 'main' into tests/cel-nginxproxy
shaun-nx 82f84a1
Merge branch 'main' into tests/cel-nginxproxy
shaun-nx b1da498
Move expected error strings to common.go
shaun-nx 80e121a
Add tests for autoscaling validation
shaun-nx 9bbe4cd
Refactor tests
shaun-nx 8612c21
Change name of `testResourceName` const
shaun-nx 45302dc
Group expexted error consts
shaun-nx 9bb4bdb
Ensure gateway CRDs are installed when running `test-cel-validation`
shaun-nx 531850d
Undo changes to `install-gateway-crds` command
shaun-nx d742467
Change `policyName` to `resourceName`
shaun-nx 216406c
Add test for when `minReplicas` is nil
shaun-nx 702ccb5
Merge branch 'main' into tests/cel-nginxproxy
shaun-nx 960db80
Have `k8sClient.Delete` use same context and `k8sClient.Create`
shaun-nx 38e20ee
Add spacing
shaun-nx aba710a
Add additional comments
shaun-nx 14ee3f7
Ensure installed resources are only delete if an error is NOT expected
shaun-nx ac12bab
Expected k8sClient.Delete to succeed
shaun-nx 55d4fe1
Merge branch 'main' into tests/cel-nginxproxy
shaun-nx 51d49f8
Add additional comments
shaun-nx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.