Skip to content

Add mirroring fraction edge case test #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Add mirroring fraction edge case test #3708

merged 2 commits into from
Aug 8, 2025

Conversation

tataruty
Copy link
Contributor

@tataruty tataruty commented Aug 8, 2025

Proposed changes

Noticed that there is no test for mirroring with Faction setting when Denominator=Numerator, when we get 100% mirroring

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@tataruty tataruty requested a review from a team as a code owner August 8, 2025 09:46
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 8, 2025
@tataruty
Copy link
Contributor Author

tataruty commented Aug 8, 2025

@bjee19 please take a look if I missed and you already have it

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.03%. Comparing base (385d5be) to head (501f496).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3708      +/-   ##
==========================================
+ Coverage   87.00%   87.03%   +0.02%     
==========================================
  Files         128      128              
  Lines       15919    15919              
  Branches       62       62              
==========================================
+ Hits        13851    13855       +4     
+ Misses       1902     1899       -3     
+ Partials      166      165       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tataruty tataruty changed the title Add mirroring fraction edge case Add mirroring fraction edge case test Aug 8, 2025
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice catch

@bjee19 bjee19 enabled auto-merge (squash) August 8, 2025 17:16
@bjee19 bjee19 merged commit e8083f7 into main Aug 8, 2025
44 checks passed
@bjee19 bjee19 deleted the test/mirroring branch August 8, 2025 17:40
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants