Skip to content

Update NGINX Plus version to R35 #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Updates NGINX Plus version to R35

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Aug 13, 2025
@salonichf5 salonichf5 marked this pull request as ready for review August 13, 2025 15:46
@salonichf5 salonichf5 requested a review from a team as a code owner August 13, 2025 15:46
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.89%. Comparing base (26ba310) to head (b072c14).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3726      +/-   ##
==========================================
- Coverage   95.19%   86.89%   -8.31%     
==========================================
  Files           1      128     +127     
  Lines         229    15962   +15733     
  Branches       62       62              
==========================================
+ Hits          218    13870   +13652     
- Misses         11     1924    +1913     
- Partials        0      168     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will just need a cherry pick into the release branch

@salonichf5 salonichf5 force-pushed the chore/updgrade-plus-version branch from e2a77c0 to 771ae9d Compare August 13, 2025 16:49
@salonichf5 salonichf5 enabled auto-merge (squash) August 13, 2025 16:50
@salonichf5
Copy link
Contributor Author

seeing this test consistently fail, i'll investigate whats happening locally

@salonichf5 salonichf5 disabled auto-merge August 13, 2025 19:34
@salonichf5 salonichf5 enabled auto-merge (squash) August 13, 2025 19:47
@salonichf5 salonichf5 merged commit ca42cd7 into main Aug 13, 2025
44 checks passed
@salonichf5 salonichf5 deleted the chore/updgrade-plus-version branch August 13, 2025 20:11
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants