Skip to content

Fix events block crash #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025
Merged

Fix events block crash #3730

merged 3 commits into from
Aug 14, 2025

Conversation

sarthyparty
Copy link
Contributor

@sarthyparty sarthyparty commented Aug 13, 2025

Proposed changes

Fixed a crash when upgrading NGF versions due to the events context being migrated.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added the bug Something isn't working label Aug 13, 2025
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.91%. Comparing base (b280a93) to head (a1f9578).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3730      +/-   ##
==========================================
+ Coverage   86.90%   86.91%   +0.01%     
==========================================
  Files         128      128              
  Lines       15965    15986      +21     
  Branches       62       62              
==========================================
+ Hits        13875    13895      +20     
- Misses       1922     1923       +1     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarthyparty sarthyparty marked this pull request as ready for review August 13, 2025 23:59
@sarthyparty sarthyparty requested a review from a team as a code owner August 13, 2025 23:59
@sarthyparty sarthyparty enabled auto-merge (squash) August 14, 2025 00:16
@sarthyparty sarthyparty disabled auto-merge August 14, 2025 00:16
@sarthyparty sarthyparty enabled auto-merge (squash) August 14, 2025 00:17
@sarthyparty sarthyparty disabled auto-merge August 14, 2025 00:32
@sarthyparty sarthyparty changed the title Fix events block error Fix events block crash Aug 14, 2025
@sarthyparty sarthyparty enabled auto-merge (squash) August 14, 2025 00:32
@sarthyparty sarthyparty merged commit 003eccc into main Aug 14, 2025
44 checks passed
@sarthyparty sarthyparty deleted the bug/worker_conns branch August 14, 2025 00:37
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 14, 2025
sarthyparty added a commit that referenced this pull request Aug 14, 2025
sjberman pushed a commit that referenced this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants