Skip to content

Add nginx one console telemetry field #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

Conversation

salonichf5
Copy link
Contributor

cherry pick PR into release 2.1

Problem: We want to know how many clusters are connected to NGINX One console.

Solution: Reports product telemetry to report if cluster is connected to NGINX One console
@salonichf5 salonichf5 requested a review from a team as a code owner August 13, 2025 22:48
@github-actions github-actions bot added enhancement New feature or request tests Pull requests that update tests labels Aug 13, 2025
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.90%. Comparing base (b6f8fcf) to head (3746bf0).
⚠️ Report is 1 commits behind head on release-2.1.

Files with missing lines Patch % Lines
internal/controller/manager.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.1    #3731      +/-   ##
===============================================
- Coverage        86.93%   86.90%   -0.03%     
===============================================
  Files              128      128              
  Lines            15962    15965       +3     
  Branches            62       62              
===============================================
- Hits             13876    13875       -1     
- Misses            1920     1924       +4     
  Partials           166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 enabled auto-merge (squash) August 13, 2025 22:53
@salonichf5 salonichf5 merged commit f8bbfdd into release-2.1 Aug 13, 2025
85 of 88 checks passed
@salonichf5 salonichf5 deleted the feat/nginx-one-console branch August 13, 2025 23:53
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 13, 2025
@sjberman sjberman changed the title Cherry pick: Add nginx one console telemetry field Add nginx one console telemetry field Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants