Skip to content

Add CEL validation tests for ObservabilityPolicy CRD #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 20, 2025
Merged

Add CEL validation tests for ObservabilityPolicy CRD #3735

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b318753
Add tests for ObservabilityPolicy CEL validation
shaun-nx Aug 14, 2025
6dac6fa
Add tests for TargetRef Kind and Name Combo
shaun-nx Aug 14, 2025
789910a
Add tests for tracing ratio strategy
shaun-nx Aug 14, 2025
ddd0271
Add additioanl test cases for `TestObservabilityPoliciesTargetRefKind…
shaun-nx Aug 14, 2025
72568ad
Add additional test for multiple duplicate targetref
shaun-nx Aug 15, 2025
697c92d
Merge branch 'main' into tests/cel-observabilitypolicy
shaun-nx Aug 15, 2025
c2286c3
Merge branch 'main' into tests/cel-observabilitypolicy
shaun-nx Aug 18, 2025
5a27110
Merge branch 'main' into tests/cel-observabilitypolicy
shaun-nx Aug 19, 2025
b62ba58
Merge branch 'main' into tests/cel-observabilitypolicy
shaun-nx Aug 20, 2025
95e0c49
Fix syntax error
shaun-nx Aug 20, 2025
6404556
Merge branch 'main' into tests/cel-observabilitypolicy
shaun-nx Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/cel/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const (
// ClientSettingsPolicy validation errors.
const (
expectedTargetRefKindError = `TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute`
expectedTargetRefGroupError = `TargetRef Group must be gateway.networking.k8s.io.`
expectedTargetRefGroupError = `TargetRef Group must be gateway.networking.k8s.io`
expectedHeaderWithoutServerError = `header can only be specified if server is specified`
)

Expand All @@ -44,6 +44,13 @@ const (
expectedMinReplicasLessThanOrEqualError = `minReplicas must be less than or equal to maxReplicas`
)

// ObservabilityPolicy validation errors.
const (
expectedTargetRefMustBeHTTPRouteOrGrpcRouteError = `TargetRef Kind must be: HTTPRoute or GRPCRoute`
expectedTargetRefKindAndNameComboMustBeUnique = `TargetRef Kind and Name combination must be unique`
expectedStrategyMustBeOfTypeRatio = `ratio can only be specified if strategy is of type ratio`
)

const (
defaultNamespace = "default"
)
Expand Down
Loading