Skip to content

Fix SnippetsFilter Functional test #3751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2025
Merged

Fix SnippetsFilter Functional test #3751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
071f3b8
Fix sf functional test
bjee19 Aug 15, 2025
09cb68e
Add wait for ready apps check
bjee19 Aug 18, 2025
69d1e3c
Add flake attempts
bjee19 Aug 19, 2025
fdc6613
Run pipeline with default nginx directives in snippets
bjee19 Aug 20, 2025
bb32261
Increase request timeout
bjee19 Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/framework/timeout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func DefaultTimeoutConfig() TimeoutConfig {
DeleteNamespaceTimeout: 150 * time.Second,
GetTimeout: 10 * time.Second,
ManifestFetchTimeout: 10 * time.Second,
RequestTimeout: 10 * time.Second,
RequestTimeout: 30 * time.Second,
ContainerRestartTimeout: 10 * time.Second,
GetLeaderLeaseTimeout: 60 * time.Second,
GetStatusTimeout: 60 * time.Second,
Expand Down
6 changes: 3 additions & 3 deletions tests/suite/manifests/snippets-filter/valid-sf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ spec:
- context: main
value: worker_priority 0;
- context: http
value: aio on;
value: aio off;
- context: http.server
value: auth_delay 10s;
value: auth_delay 0s;
- context: http.server.location
value: keepalive_time 10s;
value: keepalive_time 1h;
---
apiVersion: gateway.nginx.org/v1alpha1
kind: SnippetsFilter
Expand Down
7 changes: 4 additions & 3 deletions tests/suite/snippets_filter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ var _ = Describe("SnippetsFilter", Ordered, Label("functional", "snippets-filter

BeforeAll(func() {
Expect(resourceManager.ApplyFromFiles(snippetsFilter, namespace)).To(Succeed())
Expect(resourceManager.WaitForAppsToBeReady(namespace)).To(Succeed())
})

AfterAll(func() {
Expand Down Expand Up @@ -143,7 +144,7 @@ var _ = Describe("SnippetsFilter", Ordered, Label("functional", "snippets-filter
},
{
Directive: "aio",
Value: "on",
Value: "off",
File: fmt.Sprintf("%s%s", httpContext, httpRouteSuffix),
},
{
Expand All @@ -153,7 +154,7 @@ var _ = Describe("SnippetsFilter", Ordered, Label("functional", "snippets-filter
},
{
Directive: "auth_delay",
Value: "10s",
Value: "0s",
File: fmt.Sprintf("%s%s", httpServerContext, httpRouteSuffix),
},
{
Expand All @@ -171,7 +172,7 @@ var _ = Describe("SnippetsFilter", Ordered, Label("functional", "snippets-filter
},
{
Directive: "keepalive_time",
Value: "10s",
Value: "1h",
File: fmt.Sprintf("%s%s", httpServerLocationContext, httpRouteSuffix),
},
}),
Expand Down