-
Notifications
You must be signed in to change notification settings - Fork 141
fix: host readiness probe on ipv6 in addition to ipv4 #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @lucasl0st! Welcome to the project! 🎉 Thanks for opening this pull request! Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. |
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
3b70d70 to
59e75af
Compare
59e75af to
f3c8b91
Compare
|
The failing tests are not because of my changes right? 😅 Let me know if I need to check it further |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job
Yea I don't think those are because of your changes. We're in the middle of debugging some of these flakey pipeline test runs but you should be good. |
Problem: the readiness probe endpoint is not available on IPv6. This is a problem on IPv6 only clusters when using IPv6 for the pod network. The gateway pod refuses to come up because the readyz condition never fulfills. Example: ``` Warning Unhealthy 88s (x160 over 26m) kubelet Readiness probe failed: Get "http://[fdd3:7046:2ad5:430a:39bb:bc6d:e254:a621]:8081/readyz": dial tcp [fdd3:7046:2ad5:430a:39bb:bc6d:e254:a621]:8081: connect: connection refused ``` Solution: host the readyz endpoint on IPv6 as well.
Problem: the readiness probe endpoint is not available on IPv6. This is a problem on IPv6 only clusters when using IPv6 for the pod network. The gateway pod refuses to come up because the readyz condition never fulfills. Example: ``` Warning Unhealthy 88s (x160 over 26m) kubelet Readiness probe failed: Get "http://[fdd3:7046:2ad5:430a:39bb:bc6d:e254:a621]:8081/readyz": dial tcp [fdd3:7046:2ad5:430a:39bb:bc6d:e254:a621]:8081: connect: connection refused ``` Solution: host the readyz endpoint on IPv6 as well. Co-authored-by: Lucas Pape <[email protected]>
Proposed changes
Problem: the readiness probe endpoint is not available on IPv6. This is a problem on IPv6 only clusters when using IPv6 for the pod network. The gateway pod refuses to come up because the readyz condition never fulfills.
Example:
Solution: host the readyz endpoint on IPv6 as well.
Testing: deployed on an IPv6 only cluster, gateway pod now comes up successfully, HTTPRoutes become available.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.