Skip to content

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Aug 27, 2025

Proposed changes

Adds new make instruction to update firewall IP rule when running into VM connectivity issues with GCP.

Testing: Ran it manually and could access VM even after IP changes. make add-local-ip-to-cluster didn't work for me even after multiple tries

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@salonichf5 salonichf5 requested a review from a team as a code owner August 27, 2025 18:51
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Aug 27, 2025
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.02%. Comparing base (ac2cfc6) to head (a66754c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3802      +/-   ##
==========================================
+ Coverage   86.99%   87.02%   +0.02%     
==========================================
  Files         128      128              
  Lines       16404    16404              
  Branches       62       62              
==========================================
+ Hits        14271    14275       +4     
+ Misses       1957     1954       -3     
+ Partials      176      175       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 marked this pull request as draft August 27, 2025 18:55
@salonichf5 salonichf5 marked this pull request as ready for review August 27, 2025 18:57
@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch 2 times, most recently from ef75149 to 947c723 Compare August 27, 2025 22:23
@salonichf5 salonichf5 enabled auto-merge (squash) August 28, 2025 14:56
@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from f105a82 to a66754c Compare August 29, 2025 19:41
@salonichf5 salonichf5 merged commit 2685ad0 into main Aug 29, 2025
44 checks passed
@salonichf5 salonichf5 deleted the tests/nfr-investigation branch August 29, 2025 20:10
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants