Skip to content

Conversation

fabian4
Copy link
Contributor

@fabian4 fabian4 commented Aug 28, 2025

Proposed changes

Handle duplicate kinds in listener allowed kinds

Closes #2346

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Added a fix to handle duplicate kinds in listener allowed kinds 

Copy link

nginx-bot bot commented Aug 28, 2025

Hi @fabian4! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community label Aug 28, 2025
Copy link
Contributor

github-actions bot commented Aug 28, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@fabian4
Copy link
Contributor Author

fabian4 commented Aug 28, 2025

I have hereby read the F5 CLA and agree to its terms

Copy link
Contributor

@sarthyparty sarthyparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and nice work @fabian4! Changes pretty much lgtm, just one quick question.

EDIT: I also tested the deduplication manually via building NGF and applying a gateway listener with duplicate kinds and it looks good

Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran some manual tests on this like @sarthyparty did too
Looks good to me 🎉 nice work @fabian4 !

@fabian4 fabian4 force-pushed the handle_duplicate_kinds_in_listener_allowed_kinds branch from 1d9a7a9 to 30c0005 Compare August 29, 2025 14:29
Copy link
Contributor

@sarthyparty sarthyparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sarthyparty
Copy link
Contributor

@fabian4 Actually per @ciarams87 comment, can you make the key of both the Group and the Kind for completeness?

@fabian4 fabian4 force-pushed the handle_duplicate_kinds_in_listener_allowed_kinds branch from 30c0005 to 8942c35 Compare August 30, 2025 06:55
@fabian4 fabian4 force-pushed the handle_duplicate_kinds_in_listener_allowed_kinds branch from 8942c35 to 94134f4 Compare August 30, 2025 06:57
@fabian4 fabian4 requested a review from ciarams87 August 30, 2025 06:58
@ciarams87 ciarams87 merged commit a2a0c94 into nginx:main Aug 30, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 30, 2025
@fabian4 fabian4 deleted the handle_duplicate_kinds_in_listener_allowed_kinds branch August 30, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Handle duplicate kinds in listener allowed kinds
4 participants