-
Notifications
You must be signed in to change notification settings - Fork 137
Handle duplicate kinds in listener allowed kinds #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle duplicate kinds in listener allowed kinds #3810
Conversation
Hi @fabian4! Welcome to the project! 🎉 Thanks for opening this pull request! |
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and nice work @fabian4! Changes pretty much lgtm, just one quick question.
EDIT: I also tested the deduplication manually via building NGF and applying a gateway listener with duplicate kinds and it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran some manual tests on this like @sarthyparty did too
Looks good to me 🎉 nice work @fabian4 !
1d9a7a9
to
30c0005
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@fabian4 Actually per @ciarams87 comment, can you make the key of both the Group and the Kind for completeness? |
30c0005
to
8942c35
Compare
8942c35
to
94134f4
Compare
Proposed changes
Handle duplicate kinds in listener allowed kinds
Closes #2346
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.