-
Notifications
You must be signed in to change notification settings - Fork 139
Fix some of the NFR tests to reduce error logs and pipeline failures #3827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ead05a1
to
f53133f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3827 +/- ##
==========================================
+ Coverage 86.81% 86.82% +0.01%
==========================================
Files 128 128
Lines 16500 16500
Branches 62 62
==========================================
+ Hits 14324 14326 +2
+ Misses 1997 1996 -1
+ Partials 179 178 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f53133f
to
755a95d
Compare
cd4a559
to
35e5317
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @salonichf5 🎉
35e5317
to
0f8145f
Compare
c8be7d6
to
32cd201
Compare
32cd201
to
9647d52
Compare
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: NFR tests had errors and had pipeline failures.
Solution: I have tried to add fixes for some of the errors and fix the pipeline failures
This PR also adds
--server-side
flag to gateway API crd installationTesting: Re ran tests locally to ensure they pass
What's excluded - Not investigating longevity tests because the NGINX agent bug should solve issues around it that's being monitored and investigated of by another teammate.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #3728
Closes #3796
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.