Skip to content

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: NFR tests had errors and had pipeline failures.

Solution: I have tried to add fixes for some of the errors and fix the pipeline failures

This PR also adds --server-side flag to gateway API crd installation

Testing: Re ran tests locally to ensure they pass

What's excluded - Not investigating longevity tests because the NGINX agent bug should solve issues around it that's being monitored and investigated of by another teammate.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #3728
Closes #3796

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Sep 2, 2025
@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from ead05a1 to f53133f Compare September 2, 2025 17:31
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.82%. Comparing base (826319f) to head (9647d52).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3827      +/-   ##
==========================================
+ Coverage   86.81%   86.82%   +0.01%     
==========================================
  Files         128      128              
  Lines       16500    16500              
  Branches       62       62              
==========================================
+ Hits        14324    14326       +2     
+ Misses       1997     1996       -1     
+ Partials      179      178       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from f53133f to 755a95d Compare September 2, 2025 17:45
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Sep 2, 2025
@salonichf5 salonichf5 changed the title Fix some of the NFR tests to reduce error logs and pipeline failures Do not review: Fix some of the NFR tests to reduce error logs and pipeline failures Sep 2, 2025
@salonichf5 salonichf5 changed the title Do not review: Fix some of the NFR tests to reduce error logs and pipeline failures Fix some of the NFR tests to reduce error logs and pipeline failures Sep 3, 2025
@salonichf5 salonichf5 marked this pull request as ready for review September 3, 2025 20:34
@salonichf5 salonichf5 requested a review from a team as a code owner September 3, 2025 20:34
@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from cd4a559 to 35e5317 Compare September 3, 2025 20:40
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @salonichf5 🎉

@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from 35e5317 to 0f8145f Compare September 9, 2025 00:43
@salonichf5 salonichf5 requested a review from sjberman September 9, 2025 15:11
@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from c8be7d6 to 32cd201 Compare September 9, 2025 17:27
@salonichf5 salonichf5 enabled auto-merge (squash) September 9, 2025 17:28
@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from 32cd201 to 9647d52 Compare September 9, 2025 18:40
@salonichf5 salonichf5 merged commit ad69665 into main Sep 9, 2025
74 of 78 checks passed
@salonichf5 salonichf5 deleted the tests/nfr-investigation branch September 9, 2025 19:53
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use --server-side apply for HTTPRoute in conformance tests Investigate the deviated NFR test results for release 2.1

3 participants