Skip to content

Conversation

tataruty
Copy link
Contributor

@tataruty tataruty commented Sep 8, 2025

Proposed changes
Problem: As a developer of NGF
I want the NFR and functional tests to log as they execute
So I can more easily debug a failure when it occurs.

Solution: - Log statements are added to all non-functional and functional tests to include assertions, requests, responses, and anywhere there is a chance for an error to occur.

Testing: Tested with Plus and without, compared failures output with new logging and without

Closes ##2449

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@github-actions github-actions bot added the tests Pull requests that update tests label Sep 8, 2025
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from 8b08c8c to 3a12532 Compare September 8, 2025 11:28
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.82%. Comparing base (01cfcba) to head (0964b5c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3872      +/-   ##
==========================================
- Coverage   86.83%   86.82%   -0.02%     
==========================================
  Files         128      128              
  Lines       16500    16500              
  Branches       62       62              
==========================================
- Hits        14328    14326       -2     
- Misses       1994     1996       +2     
  Partials      178      178              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tataruty tataruty force-pushed the tests/improve_nfr_logging branch 5 times, most recently from 8da6183 to e548899 Compare September 8, 2025 19:32
@tataruty tataruty marked this pull request as ready for review September 8, 2025 20:03
@tataruty tataruty requested a review from a team as a code owner September 8, 2025 20:03
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from e1f3c02 to 5d0d9e6 Compare September 9, 2025 07:26
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from e548899 to e03b181 Compare September 9, 2025 14:28
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from e03b181 to fa481dd Compare September 9, 2025 18:54
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed tests Pull requests that update tests labels Sep 9, 2025
@tataruty tataruty self-assigned this Sep 10, 2025
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from fa481dd to 19b59f1 Compare September 10, 2025 09:24
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from 5d0d9e6 to 5e8513d Compare September 10, 2025 09:24
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from 19b59f1 to 9107bc8 Compare September 10, 2025 09:28
@github-actions github-actions bot added tests Pull requests that update tests and removed dependencies Pull requests that update a dependency file labels Sep 10, 2025
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from 9107bc8 to 802463f Compare September 10, 2025 10:27
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from 5e8513d to e9fc351 Compare September 11, 2025 08:20
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch 2 times, most recently from fdd1c0a to 56940da Compare September 11, 2025 08:56
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch 2 times, most recently from 096c177 to 3181a4c Compare September 11, 2025 10:30
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed tests Pull requests that update tests labels Sep 11, 2025
@tataruty tataruty force-pushed the tests/improve_functional_tests_logging branch from e9fc351 to bc729b5 Compare September 11, 2025 10:31
@github-actions github-actions bot added tests Pull requests that update tests and removed dependencies Pull requests that update a dependency file labels Sep 11, 2025
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from c774437 to fa83170 Compare September 11, 2025 14:58
Base automatically changed from tests/improve_functional_tests_logging to main September 11, 2025 17:09
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from fa83170 to 10392e7 Compare September 11, 2025 18:13
@tataruty tataruty force-pushed the tests/improve_nfr_logging branch from 10392e7 to d757143 Compare September 12, 2025 10:12
@tataruty tataruty merged commit c96694b into main Sep 15, 2025
44 checks passed
@tataruty tataruty deleted the tests/improve_nfr_logging branch September 15, 2025 15:43
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants