Skip to content

Conversation

@sjberman
Copy link
Collaborator

@sjberman sjberman commented Sep 8, 2025

Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.

Closes #3836

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added the enhancement New feature or request label Sep 8, 2025
@sjberman sjberman force-pushed the feat/extract-model branch 2 times, most recently from 6d6f860 to cf5b0ee Compare September 8, 2025 20:47
@sjberman sjberman marked this pull request as ready for review September 8, 2025 21:07
@sjberman sjberman requested a review from a team as a code owner September 8, 2025 21:07
Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.
@salonichf5
Copy link
Contributor

salonichf5 commented Sep 8, 2025

We should update this Readme

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 9, 2025
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@sjberman sjberman merged commit c63f9fe into nginx:feat/inference-extension Sep 9, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 9, 2025
@sjberman sjberman deleted the feat/extract-model branch September 9, 2025 16:17
@sjberman
Copy link
Collaborator Author

Turns out this function is not needed at this time, so it should be removed.

sjberman added a commit that referenced this pull request Sep 18, 2025
Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.
salonichf5 pushed a commit that referenced this pull request Oct 2, 2025
Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.
salonichf5 pushed a commit that referenced this pull request Oct 15, 2025
Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.
salonichf5 pushed a commit that referenced this pull request Oct 15, 2025
Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.
ciarams87 pushed a commit that referenced this pull request Oct 16, 2025
Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.
ciarams87 pushed a commit that referenced this pull request Oct 17, 2025
Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.
ciarams87 pushed a commit that referenced this pull request Oct 17, 2025
Problem: To support the full Gateway API Inference Extension, we need to be able to extract the model name from the client request body in certain situations.

Solution: Add a basic NJS module to extract the model name. This module will be enhanced (I've added notes) to be included in the full solution. On its own, it is not yet used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants