Skip to content

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Sep 12, 2025

Proposed changes

Fixes race detection issue in unit tests

Testing: Ran unit tests 10-15 time, saw no failures

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #3895

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@salonichf5 salonichf5 requested a review from a team as a code owner September 12, 2025 17:08
@github-actions github-actions bot added the tests Pull requests that update tests label Sep 12, 2025
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.77%. Comparing base (54135b5) to head (c383136).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3901      +/-   ##
==========================================
- Coverage   95.19%   86.77%   -8.43%     
==========================================
  Files           1      128     +127     
  Lines         229    16500   +16271     
  Branches       62       62              
==========================================
+ Hits          218    14318   +14100     
- Misses         11     2001    +1990     
- Partials        0      181     +181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@salonichf5 salonichf5 merged commit 92d2220 into main Sep 12, 2025
44 checks passed
@salonichf5 salonichf5 deleted the tests/failing-unit-tests branch September 12, 2025 17:38
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants