Skip to content

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Sep 17, 2025

Proposed changes

This change adds a new directory to tests, containing files and scripts related to IPv6 testing.
This change also adds a new make target in tests/Makfile for running the test script as well as updates the release process documentation with steps and examples on how to run the IPv6 tests.

Closes #3774

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@shaun-nx shaun-nx requested review from a team as code owners September 17, 2025 15:15
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.82%. Comparing base (8241478) to head (af1d32e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3931      +/-   ##
==========================================
- Coverage   86.83%   86.82%   -0.02%     
==========================================
  Files         128      128              
  Lines       16602    16602              
  Branches       62       62              
==========================================
- Hits        14417    14415       -2     
- Misses       2004     2005       +1     
- Partials      181      182       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shaun-nx
Copy link
Contributor Author

If anyone is curious as to why tests/suite/manifests/snippets-filter/invalid-duplicate-sf.yaml was modified, when running pre-commit locally, this file failed the yamllint check for me

yamllint.................................................................Failed
- hook id: yamllint
- exit code: 1
tests/suite/manifests/snippets-filter/invalid-duplicate-sf.yaml
  22:3      error    wrong indentation: expected 4 but found 2  (indentation)
  25:3      error    wrong indentation: expected 4 but found 2  (indentation)
  27:3      error    wrong indentation: expected 4 but found 2  (indentation)
  28:5      error    wrong indentation: expected 6 but found 4  (indentation)
  38:5      error    wrong indentation: expected 6 but found 4  (indentation)

Not sure if anyone else has hit this recently.

@shaun-nx shaun-nx requested a review from sjberman September 18, 2025 09:38
@shaun-nx
Copy link
Contributor Author

@salonichf5 thanks for the great suggestions! This actually allowed the script to only require one parameter now, which is just the TAG.

I added a few new variables to the main Makefile too just so we can override some extra options when running make helm-install-local

@shaun-nx shaun-nx requested a review from salonichf5 September 19, 2025 10:27
@salonichf5
Copy link
Contributor

salonichf5 commented Sep 19, 2025

overall looks good to me now except the last comment :)

@shaun-nx
Copy link
Contributor Author

shaun-nx commented Sep 24, 2025

overall looks good to me now except the last comment :)

Do you mind if we merge this one as is? I was trying to change this over to use the make command instead, but I needed to allow the config file for the cluster to be configurable as well. It was kinda strange, when running the command with the new variables they were't getting passed...

It's probably something small, but given that we're focusing on the Openshift stuff I want to make sure I can put the time into that instead.

@shaun-nx shaun-nx requested a review from salonichf5 September 24, 2025 15:09
@shaun-nx shaun-nx merged commit 1e7854c into main Sep 25, 2025
44 checks passed
@shaun-nx shaun-nx deleted the tests/ipv6-release-testing branch September 25, 2025 09:23
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add IPv6 environment testing workflow to ensure NGF works in IPv6-only environments

3 participants