-
Notifications
You must be signed in to change notification settings - Fork 137
Add IPv6 testing script for use in release process #3931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3931 +/- ##
==========================================
- Coverage 86.83% 86.82% -0.02%
==========================================
Files 128 128
Lines 16602 16602
Branches 62 62
==========================================
- Hits 14417 14415 -2
- Misses 2004 2005 +1
- Partials 181 182 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If anyone is curious as to why
Not sure if anyone else has hit this recently. |
@salonichf5 thanks for the great suggestions! This actually allowed the script to only require one parameter now, which is just the I added a few new variables to the main |
overall looks good to me now except the last comment :) |
Do you mind if we merge this one as is? I was trying to change this over to use the make command instead, but I needed to allow the config file for the cluster to be configurable as well. It was kinda strange, when running the command with the new variables they were't getting passed... It's probably something small, but given that we're focusing on the Openshift stuff I want to make sure I can put the time into that instead. |
Proposed changes
This change adds a new directory to
tests
, containing files and scripts related to IPv6 testing.This change also adds a new make target in
tests/Makfile
for running the test script as well as updates the release process documentation with steps and examples on how to run the IPv6 tests.Closes #3774
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.