Skip to content

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Sep 18, 2025

Revert changes to agent reload backoff settings due to a fix added in Agent v3.3.1.

Tested SnippetsFilter Functional on NGINX Plus test to ensure changes work.

@bjee19 bjee19 requested a review from a team as a code owner September 18, 2025 21:24
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 18, 2025
@bjee19
Copy link
Contributor Author

bjee19 commented Sep 18, 2025

Think this should go in the 2.1.2 patch release too?

Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.82%. Comparing base (698a369) to head (618e557).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3937      +/-   ##
==========================================
- Coverage   86.84%   86.82%   -0.02%     
==========================================
  Files         128      128              
  Lines       16559    16559              
  Branches       62       62              
==========================================
- Hits        14380    14378       -2     
- Misses       1999     2001       +2     
  Partials      180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19 bjee19 enabled auto-merge (squash) September 19, 2025 16:48
@salonichf5
Copy link
Contributor

Think this should go in the 2.1.2 patch release too?

I don't think these settings mess with anything on the agent side and should help. So we can simply let it be unless you know something I don't

@bjee19
Copy link
Contributor Author

bjee19 commented Sep 19, 2025

@salonichf5

This PR that went into agent v3.3.1, basically fixed the issue that these reload backoff settings where fixing. So with that change, these backoff settings aren't needed and could be problematic since they are different than the new defaults agent defined. So i don't see it as being necessary since I think it will work if this isn't in our 2.1.2, but I would feel like this PR should go hand in hand with the update on agent side.

@salonichf5
Copy link
Contributor

@salonichf5

This PR that went into agent v3.3.1, basically fixed the issue that these reload backoff settings where fixing. So with that change, these backoff settings aren't needed and could be problematic since they are different than the new defaults agent defined. So i don't see it as being necessary since I think it will work if this isn't in our 2.1.2, but I would feel like this PR should go hand in hand with the update on agent side.

Oh okay, if the defaults are different then I agree with you, we should add it to patch release. @sjberman thoughts?

@sjberman
Copy link
Collaborator

I agree

@bjee19 bjee19 merged commit 5188240 into main Sep 19, 2025
44 checks passed
@bjee19 bjee19 deleted the chore/update-agent-reload-backoff branch September 19, 2025 17:18
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 19, 2025
bjee19 added a commit that referenced this pull request Sep 19, 2025
Revert changes to agent reload backoff settings due to a fix added in Agent v3.3.1.

Tested SnippetsFilter Functional on NGINX Plus test to ensure changes work.
bjee19 added a commit that referenced this pull request Sep 19, 2025
Revert changes to agent reload backoff settings due to a fix added in Agent v3.3.1.

Tested SnippetsFilter Functional on NGINX Plus test to ensure changes work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants