-
Notifications
You must be signed in to change notification settings - Fork 138
Revert agent reload backoff settings #3937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Think this should go in the 2.1.2 patch release too? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3937 +/- ##
==========================================
- Coverage 86.84% 86.82% -0.02%
==========================================
Files 128 128
Lines 16559 16559
Branches 62 62
==========================================
- Hits 14380 14378 -2
- Misses 1999 2001 +2
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't think these settings mess with anything on the agent side and should help. So we can simply let it be unless you know something I don't |
This PR that went into agent v3.3.1, basically fixed the issue that these reload backoff settings where fixing. So with that change, these backoff settings aren't needed and could be problematic since they are different than the new defaults agent defined. So i don't see it as being necessary since I think it will work if this isn't in our 2.1.2, but I would feel like this PR should go hand in hand with the update on agent side. |
Oh okay, if the defaults are different then I agree with you, we should add it to patch release. @sjberman thoughts? |
I agree |
Revert changes to agent reload backoff settings due to a fix added in Agent v3.3.1. Tested SnippetsFilter Functional on NGINX Plus test to ensure changes work.
Revert changes to agent reload backoff settings due to a fix added in Agent v3.3.1.
Tested SnippetsFilter Functional on NGINX Plus test to ensure changes work.