Skip to content

Conversation

salonichf5
Copy link
Contributor

NFR test results for patch release 2.1.2

I will not merge this is, this is just for observing the test results by us to verify everything looks good.

@salonichf5 salonichf5 requested a review from a team as a code owner September 25, 2025 13:36
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Sep 25, 2025
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.89%. Comparing base (936fc8e) to head (08fd1a5).
⚠️ Report is 2 commits behind head on release-2.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.1    #3960      +/-   ##
===============================================
- Coverage        86.90%   86.89%   -0.02%     
===============================================
  Files              128      128              
  Lines            16059    16059              
  Branches            62       62              
===============================================
- Hits             13956    13954       -2     
- Misses            1932     1934       +2     
  Partials           171      171              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5
Copy link
Contributor Author

Seeing some additional error logs since this branch doesn't have the NFR test improvements so we can ignore them

Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move these under 2.1.2 instead of release-2.1.2 directories? And filenames shouldn't have the release version in them.

See the pattern for other releases.

2025/09/25 03:15:10 [emerg] 8#8: unexpected end of file, expecting "}" in /etc/nginx/conf.d/http.conf:1466
2025/09/25 03:15:14 [emerg] 8#8: unexpected end of file, expecting ";" or "}" in /etc/nginx/conf.d/http.conf:3065
2025/09/25 03:15:15 [emerg] 8#8: unexpected end of file, expecting "}" in /etc/nginx/conf.d/http.conf:3560
2025/09/25 03:15:23 [emerg] 8#8: directive "upstream" has no opening "{" in /etc/nginx/conf.d/http.conf:7773
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we're seeing these again.

Copy link
Contributor Author

@salonichf5 salonichf5 Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just what I was discussing with Ciara but this is a different issue than the agent bug

Error Set:
Get "https://cafe.example.com/tea": read tcp 10.206.0.17:60039->10.206.0.24:443: read: connection reset by peer
Get "https://cafe.example.com/tea": write tcp 10.206.0.17:44027->10.206.0.24:443: write: connection reset by peer
Get "https://cafe.example.com/tea": dial tcp 0.0.0.0:0->10.206.0.24:443: connect: connection refused
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few connection errors during the upgrade process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I know you were worried about these

Copy link
Contributor Author

@salonichf5 salonichf5 Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we create a story to track this? debugging now would definitely take long but could also lead to more community bugs and issue if it is an actual issue during upgrade

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think let's wait for another automated NFR run on main to see if it's still an issue. I don't think it's a blocker for now.

@salonichf5
Copy link
Contributor Author

Can you move these under 2.1.2 instead of release-2.1.2 directories? And filenames shouldn't have the release version in them.

See the pattern for other releases.

Does it matter? I wasn't planning on merging this unless you wanted to, then I can update

@sjberman
Copy link
Collaborator

@salonichf5 Oh I see. I'm fine with not merging then, since our 2.2 results should show improvements over 2.1

@salonichf5
Copy link
Contributor Author

Closing this PR since it was just for observing test tesults. Need to keep an eye out if these two errors occur again in NFR runs

Upgrade test

Get "https://cafe.example.com/tea": write tcp 10.206.0.17:44027->10.206.0.24:443: write: connection reset by peer

Reconfig Test

/etc/nginx/conf.d/http.conf:3560
2025/09/25 03:15:23 [emerg] 8#8: directive "upstream" has no opening "{" in /etc/nginx/conf.d/http.conf:7773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants