Skip to content

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Sep 30, 2025

Proposed changes

This change adds a new build step to build and publish the NGF Operator images.

Images will be published to ghcr.io/nginx/nginx-gateway-fabric/operator

This change also makes operator-version available as an optional field when running the Production Release workflow
image

Closes #3976

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

none

shaun-nx and others added 30 commits September 22, 2025 09:42
Add bundle, update RBAC, use root helm chart
@shaun-nx shaun-nx marked this pull request as ready for review October 2, 2025 10:39
@shaun-nx shaun-nx requested a review from a team as a code owner October 2, 2025 10:39
@shaun-nx shaun-nx changed the title DRAFT: Add Operator image build and publish to the pipeline Add Operator image build and publish to the pipeline Oct 2, 2025
@ciarams87 ciarams87 force-pushed the feat/openshift-support branch from 4504014 to 28d8e3f Compare October 2, 2025 10:46
@shaun-nx shaun-nx requested a review from ciarams87 October 2, 2025 10:48
@shaun-nx shaun-nx requested a review from a team as a code owner October 2, 2025 12:34
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 2, 2025
@shaun-nx shaun-nx requested a review from ciarams87 October 2, 2025 12:35
Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment that needs to be addressed otherwise looks good 🎉 !

@shaun-nx shaun-nx requested a review from ciarams87 October 2, 2025 14:17
@shaun-nx
Copy link
Contributor Author

shaun-nx commented Oct 2, 2025

Just one small comment that needs to be addressed otherwise looks good 🎉 !

Thanks! That should be updated now.
Updated the body of the PR as well to show what the new option looks like

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, though are there supposed to be so many commits getting merged? looks like some of them aren't from this pr

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@salonichf5
Copy link
Contributor

salonichf5 commented Oct 2, 2025

nice job, though are there supposed to be so many commits getting merged? looks like some of them aren't from this pr

just needs rebase with branch feat/openshift-support

@shaun-nx shaun-nx merged commit 8aff6fe into feat/openshift-support Oct 2, 2025
55 checks passed
@shaun-nx shaun-nx deleted the feat/pipeline-openshift-operator branch October 2, 2025 17:58
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add Operator image build and publish to the pipeline

5 participants