Skip to content

Conversation

@shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Oct 6, 2025

Proposed changes

Current `edge image for our Operator do not pass pre-flight checked due to missing maintainer lables

"failed": [
          {
              "name": "HasNoProhibitedLabels",
              "elapsed_time": 0,
              "description": "Checking if the labels (name, vendor, maintainer) violate Red Hat trademark.",
              "help": "Check HasNoProhibitedLabelsCheck encountered an error. Please review the preflight.log file for more information.",
              "suggestion": "Ensure the name, vendor, and maintainer label on your image do not violate the Red Hat trademark.",
              "knowledgebase_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction",
              "check_url": "https://access.redhat.com/documentation/en-us/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#assembly-requirements-for-container-images_openshift-sw-cert-policy-introduction"
          }
      ],

This change adds this label to the Dockerfile

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@shaun-nx shaun-nx requested a review from a team as a code owner October 6, 2025 13:54
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 6, 2025
@shaun-nx shaun-nx closed this Oct 6, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.77%. Comparing base (20d3910) to head (fdd4922).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4022      +/-   ##
==========================================
- Coverage   86.83%   86.77%   -0.06%     
==========================================
  Files         128      128              
  Lines       16607    16607              
  Branches       62       62              
==========================================
- Hits        14420    14411       -9     
- Misses       2005     2011       +6     
- Partials      182      185       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shaun-nx shaun-nx deleted the chore/operator-labels branch December 1, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants