-
Notifications
You must be signed in to change notification settings - Fork 143
Enhancement Proposal: Authentication Filter #4136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8e19dc9
Enhancement Proposal for Authentication Filter
shaun-nx 12ccfd4
Merge branch 'main' into proposal/auth-filter
shaun-nx f2e013f
Fix pre-commit errors
shaun-nx 2a7f803
Merge branch 'main' into proposal/auth-filter
shaun-nx 1b1665a
Add non-goals, test and security considerations. Move preface down to…
shaun-nx 6a36b93
Update Alternatives section to refer to new External AuthFilter doc (…
shaun-nx 601f362
Fix pre-commit errors
shaun-nx 77eb226
Merge branch 'main' into proposal/auth-filter
shaun-nx 88230d0
Set status to provisional, include only goals and non-goals
shaun-nx 5990f77
Merge branch 'main' into proposal/auth-filter
shaun-nx f65e66a
Remove diagram
shaun-nx 3d9fef4
Fix typos
shaun-nx f71701a
Merge branch 'main' into proposal/auth-filter
shaun-nx 8705cd6
Merge branch 'main' into proposal/auth-filter
shaun-nx b7e2219
Update goals and non-goals
shaun-nx b581079
Update non-goals
shaun-nx 1bed1f0
Fix pre-commit errors
shaun-nx 47894e2
Merge branch 'main' into proposal/auth-filter
shaun-nx 1ba1f3e
Update Goals and Non-goals
shaun-nx 710ef5b
Update non-goals
shaun-nx dfbb573
Merge branch 'main' into proposal/auth-filter
tataruty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Enhancement Proposal-4052: Authentiation Filter | ||
|
|
||
| - Issue: https://github.com/nginx/nginx-gateway-fabric/issues/4052 | ||
| - Status: Provisional | ||
|
|
||
| ## Summary | ||
|
|
||
| Design and implement a means for users of NGINX Gateway Fabric to enable authentication on requests to their backend applications. | ||
| This new filter should eventually expose all forms of authentication available through NGINX, both Open Source and Plus. | ||
|
|
||
| ## Goals | ||
|
|
||
| - Design a means of configuring authentication for NGF | ||
| - Design Authentication CRD with Basic Auth and JWT Auth in mind | ||
| - Determine initial resource specification | ||
| - Evaluate filter early in request processing, occurring before URLRewrite, header modifiers and backend selection | ||
| - Authentication failures return appropriate status by default (e.g., 401/403) | ||
| - Ensure response codes are configurable | ||
tataruty marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Non-Goals | ||
tataruty marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - Design for OIDC Auth | ||
| - An Auth filter for TCP and UDP routes | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.