-
Notifications
You must be signed in to change notification settings - Fork 143
Design Session Persistence - Part 1 #4158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Enhancement Proposal-4051: Session Persistence for NGINX Plus and OSS | ||
|
|
||
| - Issue: https://github.com/nginx/nginx-gateway-fabric/issues/4051 | ||
| - Status: Provisional | ||
|
|
||
| ## Summary | ||
|
|
||
| Enable NGINX Gateway Fabric to support session persistence for both NGINX Plus and NGINX OSS, allowing application developers to configure basic session persistence using the `ip_hash` load balancing method in OSS and cookie-based session persistence in NGINX Plus. | ||
|
|
||
| ## Goals | ||
|
|
||
| - Extend the Upstream Settings Policy API to allow specifying `ip_hash` load balancing method to support basic session persistence. | ||
| - Design the translation of the Gateway API `sessionPersistence` specification, which can be configured on both HTTPRoute and GRPCRoute, into NGINX Plus cookie-based session persistence directives with `secure` and `httpOnly` mode enforced by default. | ||
|
|
||
| ## Non-Goals | ||
|
|
||
| - Describe or implement low-level configuration details for enabling session persistence. | ||
| - Extend session persistence support to TLSRoutes or other Layer 4 route types. | ||
| - Supporting the `sameSite` cookie directive for NGINX Plus session persistence, which may be considered in the future as the Gateway API `sessionPersistence` specification evolves. | ||
|
|
||
| ## Useful Links | ||
salonichf5 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - Session Persistence [specification](https://gateway-api.sigs.k8s.io/reference/spec/#sessionpersistence). | ||
| - Extended Session Persistence [GEP](https://gateway-api.sigs.k8s.io/geps/gep-1619). | ||
| - RFC standard for [Set-Cookie](https://datatracker.ietf.org/doc/html/rfc6265#section-4.1) header. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.