Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Problem: We need to define the ProxySettingPolicy API and CRDs

Solution: Add ProxySettingPolicy API and CRDs

Testing: Describe any testing that you did.

Closes #4260

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested a review from a team as a code owner November 12, 2025 17:15
@github-actions github-actions bot added the enhancement New feature or request label Nov 12, 2025
@ciarams87 ciarams87 force-pushed the feat/proxy-settings-api branch from 75d14bc to ec68d7e Compare November 12, 2025 17:32
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.06%. Comparing base (e150378) to head (176aee4).
⚠️ Report is 1 commits behind head on feat/proxy-settings-policy.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           feat/proxy-settings-policy    #4266      +/-   ##
==============================================================
- Coverage                       86.11%   86.06%   -0.05%     
==============================================================
  Files                             132      132              
  Lines                           14342    14342              
  Branches                           35       35              
==============================================================
- Hits                            12350    12344       -6     
- Misses                           1789     1793       +4     
- Partials                          203      205       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 force-pushed the feat/proxy-settings-api branch from 8547c49 to 8fff74a Compare November 13, 2025 11:46
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides one comment, 🚀 !

@ciarams87 ciarams87 requested a review from a team as a code owner November 13, 2025 20:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 13, 2025
@ciarams87 ciarams87 merged commit 8181386 into feat/proxy-settings-policy Nov 13, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 13, 2025
@ciarams87 ciarams87 deleted the feat/proxy-settings-api branch November 13, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants