Skip to content

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Oct 9, 2025

Proposed changes

  • Create a new release workflow to be manually triggered instead of in the CI
  • Add GOPROXY
  • Add F5 Runner for release builds
  • Add assertion doc

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner October 9, 2025 09:50
Copy link

nginx-bot bot commented Oct 9, 2025

Hi @AlexFenlon! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community Issues or PRs opened by an external contributor label Oct 9, 2025
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 9, 2025
@AlexFenlon AlexFenlon moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller Oct 9, 2025
@danielnginx danielnginx requested a review from Copilot October 13, 2025 08:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the release workflow by creating a separate manually-triggered release workflow while maintaining the CI workflow for continuous builds. The changes enable F5-specific infrastructure (runners and Artifactory) for releases while ensuring CI builds work for both internal and forked repositories. Package distribution configurations (Homebrew, Nix, Scoop) that were previously commented out have been re-enabled for releases, and Snapcraft support has been removed.

Key Changes

  • Created a new manually-triggered release workflow (release.yml) that uses F5 infrastructure (F5 runners, Artifactory proxy) and publishes to package managers
  • Modified CI workflow to run builds without releases, using conditional runners (standard for PRs, F5 for main branch) and Artifactory proxy selection based on workflow context
  • Added assertion document generation job to both workflows for compliance tracking

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.goreleaser.yml Re-enabled Homebrew, Nix, and Scoop distribution configurations; removed Snapcraft and previously commented brew sections
.github/workflows/release.yml New workflow for manual releases with F5 infrastructure, package distribution, and assertion document generation
.github/workflows/ci.yml Updated to remove tag-based releases, add conditional runner selection, Artifactory proxy configuration, and assertion document generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexFenlon AlexFenlon requested a review from javorszky October 13, 2025 11:30
@pdabelf5 pdabelf5 requested a review from Copilot October 13, 2025 11:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexFenlon AlexFenlon enabled auto-merge (squash) October 13, 2025 14:13
@AlexFenlon AlexFenlon merged commit 6135194 into main Oct 13, 2025
16 checks passed
@AlexFenlon AlexFenlon deleted the chore/secure-build branch October 13, 2025 14:21
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks community Issues or PRs opened by an external contributor

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

3 participants