Skip to content

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Jul 17, 2024

Proposed changes

Caches were not using the variable labels.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@lucacome lucacome requested a review from a team as a code owner July 17, 2024 03:26
@github-actions github-actions bot added the bug An issue reporting a potential bug label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 3.90%. Comparing base (68df05b) to head (28ab7ca).

Files Patch % Lines
collector/nginx_plus.go 0.00% 59 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #780      +/-   ##
========================================
- Coverage   3.93%   3.90%   -0.04%     
========================================
  Files          5       5              
  Lines       1297    1307      +10     
========================================
  Hits          51      51              
- Misses      1246    1256      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome added this to the v1.3.0 milestone Jul 17, 2024
@lucacome lucacome merged commit 082ec9f into main Jul 24, 2024
15 of 16 checks passed
@lucacome lucacome deleted the fix/cache branch July 24, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants