Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 21, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/prometheus/client_golang v1.20.4 -> v1.20.5 age adoption passing confidence

Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.20.5: / 2024-10-15

Compare Source

We decided to revert the testutil change that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the exact error message.

Going forward, we plan to reinforce our release testing strategy [1],[2] and deliver an enhanced testutil package/module with more flexible and safer APIs.

Thanks to @​dashpole @​dgrisonnet @​kakkoyun @​ArthurSens @​vesari @​logicalhan @​krajorama @​bwplotka who helped in this patch release! 🤗

Changelog

[BUGFIX] testutil: Reverted #​1424; functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. #​1645


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner October 21, 2024 07:42
@renovate renovate bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 21, 2024
@renovate renovate bot enabled auto-merge (squash) October 21, 2024 07:42
@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.31%. Comparing base (182138f) to head (aa51d41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #885   +/-   ##
=====================================
  Coverage   4.31%   4.31%           
=====================================
  Files          5       5           
  Lines       1438    1438           
=====================================
  Hits          62      62           
  Misses      1376    1376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

| datasource | package                             | from    | to      |
| ---------- | ----------------------------------- | ------- | ------- |
| go         | github.com/prometheus/client_golang | v1.20.4 | v1.20.5 |


Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/github.com-prometheus-client_golang-1.x branch from 2923859 to aa51d41 Compare October 25, 2024 08:38
@renovate renovate bot merged commit 004f606 into main Oct 25, 2024
15 checks passed
@renovate renovate bot deleted the renovate/github.com-prometheus-client_golang-1.x branch October 25, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants