Add support for assuming the role specified in AWS_ROLE_ARN when not using WebIdentity#121
Draft
atom-andrew wants to merge 1 commit intonginx:masterfrom
Draft
Add support for assuming the role specified in AWS_ROLE_ARN when not using WebIdentity#121atom-andrew wants to merge 1 commit intonginx:masterfrom
atom-andrew wants to merge 1 commit intonginx:masterfrom
Conversation
…ILE is missing Allow use of AssumeRole to assume the desired identify when web identity is not in use Also update some signature code to explicitly pass through the desired method instead of assuming it matches the request. Finally, make it more obvious in signature code that signed components are path rather than a full uri.
Collaborator
|
This PR has been in a draft state for some time. Can I answer any questions or help in any way? |
|
@atom-andrew any chance that this PR will be completed? We're looking for this feature as well. Thanks! |
Author
|
Hi @igor-nikiforov , thanks for reaching out. I don't have plans to continue work on this but please feel free to pick it up and run with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assume the role specified in AWS_ROLE_ARN if AWS_WEB_IDENTITY_TOKEN_FILE is missing.
Also update some signature code to explicitly pass through the desired method instead of assuming it matches the request. Finally, make it more obvious in signature code that signed components are path rather than a full uri.