Skip to content

ci(fix): Properly auto-update Dockerfiles using a build arg #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2024
Merged

ci(fix): Properly auto-update Dockerfiles using a build arg #309

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdee1df
ci(fix): Properly auto-update Dockerfiles using a build arg
alessfg Aug 29, 2024
4556fee
update Dockerfile
alessfg Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Dockerfile.buildkit.plus
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ARG RELEASE=bookworm
FROM debian:${RELEASE}-slim@sha256:f528891ab1aa484bf7233dbcc84f3c806c3e427571d75510a9d74bb5ec535b33
# ARG RELEASE=bookworm # Removing for the time being since it doesn't play well with Dependabot
FROM debian:bookworm-slim@sha256:f528891ab1aa484bf7233dbcc84f3c806c3e427571d75510a9d74bb5ec535b33

# Persist RELEASE argument
ARG RELEASE
# Create RELEASE argument
ARG RELEASE=bookworm

# NJS env vars
ENV NGINX_VERSION=32
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile.plus
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ARG RELEASE=bookworm
FROM debian:${RELEASE}-slim@sha256:f528891ab1aa484bf7233dbcc84f3c806c3e427571d75510a9d74bb5ec535b33
# ARG RELEASE=bookworm # Removing for the time being since it doesn't play well with Dependabot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are removing it let's just delete it for now

FROM debian:bookworm-slim@sha256:f528891ab1aa484bf7233dbcc84f3c806c3e427571d75510a9d74bb5ec535b33

# Persist RELEASE argument
ARG RELEASE
# Create RELEASE argument
ARG RELEASE=bookworm

# NJS env vars
ENV NGINX_VERSION=32
Expand Down