Skip to content

fix: Preserve AWS_CONTAINER_CREDENTIALS_RELATIVE_URI in nginx.conf #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: Preserve AWS_CONTAINER_CREDENTIALS_RELATIVE_URI in nginx.conf #362

merged 1 commit into from
Feb 10, 2025

Conversation

fmtng
Copy link
Contributor

@fmtng fmtng commented Jan 28, 2025

"AWS_CONTAINER_CREDENTIALS_RELATIVE_URI" is set when "00-check-for-required-env.sh" runs. In "awscredentials.js" -> "fetchCredentials", however, the "AWS_CONTAINER_CREDENTIALS_RELATIVE_URI" is not set anymore and erroneously, "_fetchEC2RoleCredentials" instead of "_fetchEcsRoleCredentials" is called.

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords in this PR description (not in the title of the PR).

Checklist

Before creating a pull request (PR), run through this checklist and mark each as complete:

"AWS_CONTAINER_CREDENTIALS_RELATIVE_URI" is set when "00-check-for-required-env.sh" runs. In "awscredentials.js" -> "fetchCredentials", however, the "AWS_CONTAINER_CREDENTIALS_RELATIVE_URI" is not set anymore and erroneously, "_fetchEC2RoleCredentials" instead of "_fetchEcsRoleCredentials" is called.
Copy link

github-actions bot commented Jan 28, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@fmtng
Copy link
Contributor Author

fmtng commented Jan 28, 2025

I have hereby read the F5 CLA and agree to its terms

@fmtng fmtng changed the title Fix nginx.conf to preserve AWS_CONTAINER_CREDENTIALS_RELATIVE_URI fix: Preserve AWS_CONTAINER_CREDENTIALS_RELATIVE_URI in nginx.conf Jan 28, 2025
Copy link
Collaborator

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@dekobon dekobon merged commit 44099e7 into nginx:main Feb 10, 2025
10 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants