fix: Preserve AWS_CONTAINER_CREDENTIALS_RELATIVE_URI in nginx.conf #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"AWS_CONTAINER_CREDENTIALS_RELATIVE_URI" is set when "00-check-for-required-env.sh" runs. In "awscredentials.js" -> "fetchCredentials", however, the "AWS_CONTAINER_CREDENTIALS_RELATIVE_URI" is not set anymore and erroneously, "_fetchEC2RoleCredentials" instead of "_fetchEcsRoleCredentials" is called.
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Contributor
Author
|
I have hereby read the F5 CLA and agree to its terms |
fmtng
changed the title
dekobon
approved these changes
Feb 10, 2025
Collaborator
dekobon
left a comment
dekobon
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"AWS_CONTAINER_CREDENTIALS_RELATIVE_URI" is set when "00-check-for-required-env.sh" runs. In "awscredentials.js" -> "fetchCredentials", however, the "AWS_CONTAINER_CREDENTIALS_RELATIVE_URI" is not set anymore and erroneously, "_fetchEC2RoleCredentials" instead of "_fetchEcsRoleCredentials" is called.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords in this PR description (not in the title of the PR).
Checklist
Before creating a pull request (PR), run through this checklist and mark each as complete:
README.md).